-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add wrapper types for all integer/float (de)serialization #322
Conversation
PR missing one of the required labels: {'documentation', 'internal', 'dependencies', 'enhancement', 'breaking-change', 'bug', 'new feature'} |
All serializer(lambda i: ZBytes.serialize(Int64(i)), target=int)
deserializer(lambda zbytes: zbytes.deserialize(Int64), target=int)
serializer(lambda f: ZBytes.serialize(Float64(f)), target=float)
deserializer(lambda zbytes: zbytes.deserialize(Float64), target=float) |
Float32
for f32 (de)serialization
I'd go for keeping |
I've added |
zenoh/__init__.pyi
Outdated
@@ -54,7 +90,7 @@ class Config: | |||
def from_file(cls, path: str | Path) -> Self: ... | |||
@classmethod | |||
def from_json5(cls, obj: Any) -> Self: ... | |||
@property | |||
property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is @property -> property
a wanted change or some simple error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a typo indeed, I'm fixing it
No description provided.